Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a codegen check to the CI #78

Closed
wants to merge 2 commits into from
Closed

Conversation

notgull
Copy link
Collaborator

@notgull notgull commented Aug 25, 2023

This ensures that all generated code is up to date.

This ensures that all generated code is up to date.

Signed-off-by: John Nunley <[email protected]>
Signed-off-by: John Nunley <[email protected]>
@RazrFalcon
Copy link
Collaborator

Sorry, but I don't think this is a good idea. I don't want to have a complicated CI.
Especially building C from sources. A minor GCC/autotools update and good luck figuring out what is wrong. Nah.

Also, you cannot really forget to update those files, because tests would be failing.

@notgull
Copy link
Collaborator Author

notgull commented Aug 26, 2023

Okay, I'll reopen it once there is progress on taiki-e/install-action#199

@notgull notgull closed this Aug 26, 2023
@notgull notgull deleted the ragel-ci branch August 26, 2023 00:50
@RazrFalcon
Copy link
Collaborator

No, I don't think we need any changes to CI at all. It's fine.

@notgull
Copy link
Collaborator Author

notgull commented Aug 26, 2023

Are you sure? I help maintain x11rb, which uses a lot of pre-generated code. Having a check like this is invaluable for preventing the usual mistake of "forgot to run the build scripts again".

@RazrFalcon
Copy link
Collaborator

forgot to run the build scripts again

It would not happen, because tests would fail. We have almost 2000 tests. The chance you forget something is tiny.
Again, simplicity is king. The current CI is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants